Define open_timeout for get_ec2_metadata_region
#173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While developing some AMI provisioning tools locally, we attempt to
install the CodeDeploy agent. Unfortunately, the process was hanging
indefinitely.
Digging into the process using `strace`, it is stuck on a `connect` to
the EC2 metadata service.
```
connect(7, {sa_family=AF_INET, sin_port=htons(80), sin_addr=inet_addr("169.254.169.254")}, 16
```
This is due to the metadata service not being present in our local
development environment and the installer isn't able to resolve the
service.
After locating this in the installation script, I can see there is a
(very high) read timeout however there isn't an open timeout which is
what the process will use to restrict the amount of time a connection
can be pending a connection. This is particularly useful if the service
you are attempting to connect to is either unresponsive to accept the
connection or not reachable due to things like DNS resolution.
To address the issue, I've added an open timeout to the `open` call and
now the process fails as expected after a sensible 3s.
Consolidate the HTTP options for OpenURI `read` calls to use the same settings. This extends the work done in e7b4ff0 to include a `open_timeout` so that these calls are not subject to potentially the same issue with being unable to establish a connection remotely.
|
@jacobbednarz can you use pull request template ? |
|
Hey @rohkat-aws! Thanks for the speedy response! I'm happy to amend my Pull Request to include the mention of the agreement to the Apache 2.0 License however I'm curious regarding the background on why this is a requirement considering the license itself already outlines this is a prerequisite. From section 5 of the Apache 2.0 license:
Based on my understanding of this, the agreement already assumed and the only reason I would need to mention anything in this space was if I had a separate licensing agreement already in place. |
|
@hyandell can you please respond to this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing some AMI provisioning tools locally, we attempt to
install the CodeDeploy agent. Unfortunately, the process was hanging
indefinitely.
Digging into the process using
strace, it is stuck on aconnecttothe EC2 metadata service.
This is due to the metadata service not being present in our local
development environment and the installer isn't able to resolve the
service.
After locating this in the installation script, I can see there is a
(very high) read timeout however there isn't an open timeout which is
what the process will use to restrict the amount of time a connection
can be pending a connection. This is particularly useful if the service
you are attempting to connect to is either unresponsive to accept the
connection or not reachable due to things like DNS resolution.
To address the issue, I've added an open timeout to the
opencall andnow the process fails as expected after a sensible 3s.
Included in this PR is a change extracting out the HTTP options that are
shared by the OpenURI
read/opencalls to consolidate theconfiguration. This also introduces an
open_timeoutto thesesettings to mitigate the potential issue for these calls in the event
the service is unreachable for whatever reason.